Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index




On 2017/03/07 1:58 PM, Bjoern Michaelsen wrote:
FWIW: the changes are along the lines of:

-    mpPage = pPage;
+    mpPage = VclPtr<TabPage>(pPage);

with mpPage being a VclPtr<> and pPage being a raw pointer.


I can't see how that would flush out any bugs. How could it go wrong? Whether it is null or not makes no difference, the VclPtr<T> is happy either way.

What is more likely to flush out bugs (and what would make sberg very happy), would be to remove the current auto-conversion-to-T* operator, since that would make explicit the places where we are passing around raw pointers instead of VclPtr<T>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.