Hi Filippo, On Wednesday, 2016-12-14 09:59:28 +0000, Filippo giacchè wrote:
-why there is no need to modify that function?
Because it is called only in one place and that place in turn is called very rarely. There's almost no gain over all if only MatCopy() alone was optimized, despite that it proabbly can't, unless the underlying matrix structures/algorithms are touched from which all matrix functions could benefit, which would involve getting acquainted with mdds::multi_type_matrix that is about the hardest stuff you can get into.
there are many function with "fixme" near them (in core/sc/source/core/tool/scmatrix.cxx), are they not to be modified/optimized?
Check with git annotate who introduced that when (and maybe why).
- what is the main goal of this task (tdf#bug 89387) ?
Łukasz in https://bugs.documentfoundation.org/show_bug.cgi?id=89387#c37 already gave hints where to look at. Actually I don't get why that task is marked as an EasyHack with difficultyBeginner, it should be at least difficultyInteresting.. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack
Attachment:
signature.asc
Description: PGP signature