Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


On Thu, Oct 08, 2015 at 01:03:15PM +0200, Michael Stahl wrote:
uhm... did you just use "boost::signal2" and "trivial" in the same
sentence?  are you aware that a single #include
<boost/signal2/signal.hpp> adds a ludicrous 33 KLOC of included headers?

FWIW, from the top of my head, we have at least:

 - SwClient/SwNotify
 - tools/link.hxx
 - SfxBroadcaster/SfxListener

and a bazillion other implementations that I forgot about of the observer
pattern in LibreOffice. I would much prefer _not_ to introduce yet another
implementation, but rather use the least broken of our own.

And if something like boost::signal2 is awesome beyond believe (which is --
given Michaels hint about LOCs added at least open to debate), we should first
make our least broken implementation wrap or subclass that as a migration path.

Best,

Bjoern

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.