Re: Problem in Bug 93240

On Tue, Sep 1, 2015 at 11:50 AM, Shreyansh Gandhi <gandhishrey@gmail.com>
wrote:

> Hey, I don't understand the reason why the build failed. Can you please
> take a look?
> http://ci.libreoffice.org/job/lo_gerrit_master/5856/console
Looks like a Jenkins issue. Other builds have failed as well.

Rebase to rebuild again later when Jenkins shows some successful builds.


> On Tue, Sep 1, 2015 at 8:06 PM Michael Stahl <mstahl@redhat.com> wrote:
>
> > On 01.09.2015 15:34, Shreyansh Gandhi wrote:
> > > I just came across
> > > this:
> > http://stackoverflow.com/questions/24221955/creating-a-unique-ptr-from-a-pointer
> > .
> > > Will it be safe to use this method to push_back into m_Selectors?
> >
> > yes, if it was pushing to a boost::ptr_container before (and we can
> > assume that that works), then converting it to a unique_ptr only at the
> > place when it is pushed is doing exactly the same thing.
> >
> > the only problem to watch out for, if you do it earlier and convert a
> > variable declaration to std::unique_ptr then std::move into the
> > container then the variable contains a null pointer now - but if you
> > convert the bare pointer only inside the push_back call then this
> > problem is avoided.
> >
> >
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> --
> Regards,
> Shreyansh Gandhi
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice