dociter.cxx: really suspicious use of ! in condition

Matteo Casalin <matteo.casalin -AT- yahoo.com>
Wed, 18 Feb 2015 11:51:21 +0100

Hi all,
    while looking at 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 I 
noticed a really suspicious use of ! on the same line that was modified:

&& ! nMinNextEnd < nRow

Based on the 'n' prefix and the related usage of ! in conditionals on integers, I would say that 
that should be !(nMinNextEnd < nRow) or nMinNextEnd >= nRow

Sadly I don't have time to propose a patch in gerrit for review. Does anybody have a clue on what 
should go there, how to test the results and, if needed, patch the code?

Cheers
Matteo

Context

sc/source/core/data/dociter.cxx: really suspicious use of ! in condition · Matteo Casalin
- Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition · Stephan Bergmann
  - Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition · Matteo Casalin
    - Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition · Stephan Bergmann
      - Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition · Németh László

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.