Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


Hi Stephan,
    thanks for looking into this.
That code was already there - could it be that for some reason the plugin was used for that file 
but did not detect that instance?

Kind regards
Matteo

On Wed, 18 Feb 2015 12:53:34 +0100
Stephan Bergmann <sbergman@redhat.com> wrote:

On 02/18/2015 11:51 AM, Matteo Casalin wrote:
     while looking at 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002
 I noticed a really suspicious use of ! on the same line that was modified:

&& ! nMinNextEnd < nRow

mistakes like this (which appears to already have been fixed) are 
automatically found by loplugin:implicitboolconversion
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.