Re: Performance samples for LibreOffice ...

> Hi Matus,
>
>       Any chance you can fix / commit this one ? :-)
>
>       Jan - wow - that is a nice error =) are there any other ODR issues ?
> they habitually bite us hard so ... great to get libmerged debugged even
> more. CC'ing the list too.

I have patch in way for type & virtual tables ODR checking (the problem is that
it requires us to stream mangled type names to establish ODR equivalency at
link time. This adds extra 2% of streaming that I need to justify).  Current
mainline (I used for my test) reports ODR violation only for types with virtual
tables.  I will check if I notice more and will try to run it with full ODR
checking enabled.

I also want to add a way to dump the translation unit, because often these are
caused by different #defines or by -funsigned-char/-fsigned-char differences.
In those cases the erros output are quite puzzling ;)

Honza
>       Thanks !
>
>               Michael.
>
>
> On Fri, 2014-08-22 at 17:05 +0200, Jan Hubicka wrote:
> > Hi,
> > this is another warning that may be worth fixing
> > /aux/hubicka/libreoffice/sc/source/ui/vba/vbastyles.cxx:68:7: warning: type �struct 
> > EnumWrapper� violates one definition rule [-Wodr]
> >  class EnumWrapper : public EnumerationHelper_BASE
> >        ^
> > /aux/hubicka/libreoffice/sc/source/ui/vba/vbaoleobjects.cxx:74:7: note: a different type is 
> > defined in another translation unit
> >  class EnumWrapper : public EnumerationHelper_BASE
> >        ^
> > /aux/hubicka/libreoffice/sc/source/ui/vba/vbastyles.cxx:70:50: note: the first difference of 
> > corresponding definitions is field �m_xIndexAccess�
> >          uno::Reference<container::XIndexAccess > m_xIndexAccess;
> >                                                   ^
> > /aux/hubicka/libreoffice/sc/source/ui/vba/vbaoleobjects.cxx:77:43: note: a field with different 
> > name is defined in another translation unit
> >          uno::Reference<XHelperInterface > m_xParent;
>
> -- 
>  michael.meeks@collabora.com  <><, Pseudo Engineer, itinerant idiot