Re: Performance samples for LibreOffice ...

On 09/11/2014 07:05 AM, Jan Hubicka wrote:
> /aux/hubicka/libreoffice/i18npool/inc/transliteration_Ignore.hxx:36:7: warning: type ‘struct 
> transliteration_Ignore’ violates one definition rule [-Wodr]
>   class transliteration_Ignore : public transliteration_commonclass
>         ^
> /aux/hubicka/libreoffice/i18npool/inc/transliteration_Ignore.hxx:36:7: note: a different type is 
> defined in another translation unit
>   class transliteration_Ignore : public transliteration_commonclass
>         ^
> /aux/hubicka/libreoffice/i18npool/inc/transliteration_Ignore.hxx:74:24: note: the first difference 
> of corresponding definitions is field ‘map’
>           const Mapping *map;
>                          ^
> /aux/hubicka/libreoffice/i18npool/inc/transliteration_Ignore.hxx:74:24: note: a field of same name 
> but different type is defined in another translation unit
>           const Mapping *map;
>                          ^
> /aux/hubicka/libreoffice/include/i18nutil/casefolding.hxx:51:0: note: type ‘const struct Mapping’ 
> should match type ‘const struct Mapping’ but is defined in different namespace
>   struct Mapping
>   ^
> /aux/hubicka/libreoffice/i18npool/inc/transliteration_Ignore.hxx:32:3: note: the incompatible type 
> is defined here
>   } Mapping;
>     ^

Fixed as 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=d9645bf8a1c1c95aeeb9a90b89387d82795f56dd> 
"Prevent erroneous pick up of unrelated css::i18n::Maping" now.  Shudder.

> /aux/hubicka/libreoffice/xmloff/source/core/XMLEmbeddedObjectImportContext.cxx:44:0: warning: type 
> ‘struct XMLServiceMapEntry_Impl’ violates one definition rule [-Wodr]
>   struct XMLServiceMapEntry_Impl
>   ^
> /aux/hubicka/libreoffice/xmloff/source/core/xmlexp.cxx:118:0: note: a different type is defined in 
> another translation unit
>   struct XMLServiceMapEntry_Impl
>   ^
> /aux/hubicka/libreoffice/xmloff/source/core/XMLEmbeddedObjectImportContext.cxx:46:0: note: the 
> first difference of corresponding definitions is field ‘eClass’
>       enum XMLTokenEnum eClass;
>   ^
> /aux/hubicka/libreoffice/xmloff/source/core/xmlexp.cxx:120:0: note: a field with different name is 
> defined in another translation unit
>       const sal_Char *sModelService;
>   ^

Fixed as 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4494c33e4114f194262c4ad202a3eafca41fba7> 
"Avoid ODR-violating name clash" now.

> /aux/hubicka/libreoffice/svx/source/form/tabwin.cxx:76:0: warning: type ‘struct ColumnInfo’ 
> violates one definition rule [-Wodr]
>   struct ColumnInfo
>   ^
> /aux/hubicka/libreoffice/xmloff/source/table/XMLTableImport.cxx:54:0: note: a different type is 
> defined in another translation unit
>   struct ColumnInfo
>   ^
> /aux/hubicka/libreoffice/svx/source/form/tabwin.cxx:78:0: note: the first difference of 
> corresponding definitions is field ‘sColumnName’
>       OUString sColumnName;
>   ^
> /aux/hubicka/libreoffice/xmloff/source/table/XMLTableImport.cxx:56:0: note: a field with different 
> name is defined in another translation unit
>       OUString msStyleName;
>   ^

Fixed as 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=4d3c88805d1917932ee88a0f22ae93c43e8e389a> 
"Avoid ODR-violating name clash" now.

Stephan