Re: Cppcheck redundantAssignment gridcell.cxx (svx module)

On Sat, 2014-02-01 at 14:30 -0800, julien2412 wrote:
> See
> http://dev-builds.libreoffice.org/cppcheck_reports/master/888.html#line-2150
>
> I would tend to remove the last line (because GetCorrectedValue, the line
> before, isn't used for the moment) but I wouldn't like to create some
> regression.
>
> Any idea?

I wonder if this is the implementation of the Currency Field of
view->toolbars->form controls->more controls->currency field or
something different ?

Either way, checking with git, this seems to have come in for
https://issues.apache.org/ooo/show_bug.cgi?id=18045 via
2ee88bdef436d13d9c5d6b1a5b45dcc18c18de21

So, I'm tempted to remove the last sValue = ... line seeing as the
intent from the commit seems to suggest that the result of the
intermediate lines is the desired outcome. I suggest you have a look a
the original bugreport and see the original bug stays fixed anyway if
you do that.

C.