Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


Hello,

Cppcheck reported this:
svx/source/fmcomp/gridcell.cxx
2150    redundantAssignment     style   Variable 'sValue' is reassigned a value
before the old one has been used.

                if ( !_rxField->wasNull() )
                {
                    _rField.SetValue( fValue );
                    BigInt aValue = _rField.GetCorrectedValue();
                    sValue = aValue.GetString();
                    sValue = _rField.GetText();<--- Variable 'sValue' is
reassigned a value before the old one has been used.

See
http://dev-builds.libreoffice.org/cppcheck_reports/master/888.html#line-2150

I would tend to remove the last line (because GetCorrectedValue, the line
before, isn't used for the moment) but I wouldn't like to create some
regression.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-redundantAssignment-gridcell-cxx-svx-module-tp4095032.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.