Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hey,


2013/11/11 Kohei Yoshida <kohei.yoshida@collabora.com>

Hi there,

Eike brought to my attention that my recent change to use the internal
API to import formulas from xlsx broke the extra handling that the UNO
API was doing to translate some of the newer Excel functions from Excel
2010 and newer.  These new functions are typically prefixed with _xlfn.
in the XML stream so that when the function name is e.g. BETA.DIST, it
would appear as _xlfn.BETA.DIST in the sheet stream where the formula
cell is stored.

Long story short, the way I've decided to solve this was to add another
set of function names and associate it with formula language XL_ENGLISH,
which is, for now, only used for importing xlsx in a significant way.

So, when you guys have implemented these new functions in Calc core, but
have trouble importing them from xlsx, please take a look at resource
RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML in
formula/source/core/resource/core_resource.src and see if the stored
function name matches what's in the XML stream.

Hopefully this fixes the old functionality from the UNO formar parser
that we were missing in ScCompiler.


And a small request by me. Could we maybe add always directly an
import/export test when we add a new function?

Adding an import/export test for a function is normally a task of a few
minutes and should help us prevent regressions with these functions.

Regards,
Markus

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.