Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 25/04/13 10:35, Noel Grandin wrote:
Hi

I would like to discuss the addition of conversion operators for UNO. 
Let me start with an example.
If we have IDL that looks like:
    interface A {}
    interface B : A {}

Then we typically have C++ code that looks like
   void foo(Reference<A> a)
   void bar() {
       Reference<B> b = ....
       methodThatTakesA( Reference<A>(b, UNO_QUERY_THROW) );
   }

I want to change things so that I can write:
   void bar() {
       Reference<B> b = ....
       methodThatTakesA( b );
   }
and have the code automagically perform the B to A conversion

Is there some reason this would not be desirable?

one reason may be that queryInterface calls are relatively expensive, so
it is better to have them explicit so you are aware that they happen.

e.g. this problem here caused a 3 % or so slowdown in ODF file load
and/or save (i forgot which), mainly due to 2 additional queryInterface
calls in a critical place:
https://issues.apache.org/ooo/show_bug.cgi?id=108161

with your proposal it would be possible to write code like:

        Reference<B> b = ...
        methodFooThatTakesA( b );
        methodBarThatTakesA( b );
        methodBazThatTakesA( b );

... and get 3 queryInterface calls instead of 1.

or let me reformulate that: is it possible to implement your
hypothetical operator such that it does not call queryInterface (i don't
know).




Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.