Re: fdo#55814: unit test is missing

On Sat, 2013-03-09 at 14:29 +0100, David Ostrovsky wrote:
> i've been told yesterday that the usage of writer is severly restricted.
> All versions since 3.5 are affected. There is a bug for it:
> https://bugs.freedesktop.org/show_bug.cgi?id=55814

        Nasty.

> I wonder why we don't have any unit test for that part of code?

        No-one wrote it yet ? :-) it's hardish to implemnt writer unit-tests
even now ? ( at least my attempt at auto-testing the red-lining also ran
into the ground inconclusively before I could write code to test the
specific issue that was reported ;-)

> Another question is bug prioritization. That one is clearly a blocker 
> for me, and belongs on ESC list of most critical bugs we have and should take 
> care of.

        So - it should be a MAB - mark it a dependency of:

https://bugs.freedesktop.org/showdependencytree.cgi?id=44446&hide_resolved=1
        
> How can i create a unit test for that? Could you point me to some 
> similar writer tests ?

        So - of course, fiddling with the raw core API is one way to construct
such a document checkout:

        sw/qa/core/uwriter.cxx

        But apparently simple stuff such as inserting text into a document
there is far less than obvious and clean (in my experience at least).

> I would expect that programmatic construction of such a document 
> shouldn't be hard.

        ;-) personally I'd load the document to remove that problem; Miklos has
a load of tests vs. the RTF filter here:

        sw/qa/extras/rtfimport.cxx

        that do UNO driven testing of document structure that are prolly well
worth pillaging there :-)

        ATB,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot