Re: [RFC] syslog output from SAL_* messages

Hi Miklos,

Il 18/12/2012 10:04, Miklos Vajna ha scritto:
> Hi Riccardo,
>
> On Tue, Dec 18, 2012 at 09:55:23AM +0100, Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>  
> wrote:
> > I totally overlooked this :) shouldn't i have seen the WARNs though?
>
> IIRC you get WARNs only with dbglevel>  0 (i.e. when you configure with
> --enable-debug or --enable-dbgutil)

Ah! I think i'll stick with SAL_INFO then.

> > In sal/osl/all/log.cxx:87 getEnvironmentVariable "+WARN" is default
> > when std::getenv("SAL_LOG") == 0. Btw in practice probably doesn't
> > count but shouldn't these be checks against NULL instead of 0?
>
> http://c-faq.com/null/nullor0.html
>
> I think that's true for C++ as well.

Sure, i think am a fan of "a gentle reminder that a pointer is involved" 
convention.

thanks,
riccardo