Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Il 18/12/2012 11:52, Tor Lillqvist ha scritto:
- am not able to send the ENABLE_SYSLOG definition down to
sal/osl/unx/salinit.cxx

Surely the tradityional name for this should be HAVE_SYSLOG_H ?
ENABLE_FOO things are for stuff you enable or disable on the configure
command line, not for results of checks of header file presence. (Of
course, it might be that there are counter-examples in LO's
configure.ac, but we shouldn't continue to follow such anti-patterns.)

I guess you need to add to config/config_global.h.in:
#undef HAVE_SYSLOG_H

and change the test to a simple:
AC_CHECK_HEADERS(syslog.h) ?

Isn't that the simple, normal way to check for some header?

Yep, and differently from my previous approach it even works :)

thanks,
riccardo

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.