Re: random number generators for calc

Hey

2012/12/7 tino <ttk448@gmail.com>:
> > > Small problems:
> > >  - compiler warnings from within boost
> >
> > We need to patch them out otherwise the Werror build will fail. It
> > seems that these warnings are also fixed upstream.
>
> This really confuses me. The warnings I'm getting are of the form
>
>  ...boost/random/binomial_distribution.hpp:47:5: warning:
>  declaration of 'p' shadows a member of 'this' [-Wshadow]
>
> I'm also getting similar warnings even with boost 1.52, however only
> if boost resides in a non-standard directory. Linking boost to
>
>  /usr/local/include
>
> and using -I/usr/local/include makes all the -Wshadow warnings
> disappear.
>
> Don't know if you can confirm this but this is beyond me:
>
> # ln -s .../core/solver/unxlngx6.pro/inc/external/boost /usr/local/include
> # ln -s .../core/solver/unxlngx6.pro/inc/external/boost /tmp/include
>
> $ cd .../core/sc/source/core/tool
> $ g++ -Wall -Wshadow -c random.cxx -I/tmp/include
> ... [warnings] ...
>
> $ g++ -Wall -Wshadow -c random.cxx -I/usr/local/include
> [no warning]

It is actually only partly fixed upstream.
I opened boost#7774 for the missing change and fixed it for our
internal boost with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=632cdffd08df8cdaeba47c6c42c7f718aaf9e751

I'll have a look at the remaining parts now.

Regards,
Markus