Hi Enrico, On Thursday, 2012-11-15 12:24:08 +0100, Enrico Weigelt wrote:
I'm currently working on removing unused functions (mentioned in unused.easy). Should I do it one by one with separate commits or in one big commit ? An big commit would make it easier/quicker for me (as I dont need so many rebuilds), but perhaps could make review a bit harder.
Much preferred to split them up instead of having one large patch that's diffcult to review. Maybe a good chunk size would be per module patches. This also helps to find a reviewer who is familiar with the code in question. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
Attachment:
pgp8btWXVB7D1.pgp
Description: PGP signature