On Thu, Nov 15, 2012 at 5:24 AM, Enrico Weigelt <enrico.weigelt@vnc.biz> wrote:
Hi folks,
I'm currently working on removing unused functions (mentioned
in unused.easy). Should I do it one by one with separate commits
or in one big commit ?
An big commit would make it easier/quicker for me (as I dont
need so many rebuilds), but perhaps could make review a bit
harder.
and increase the odd that the patch would get rejected for removing
something that _is_ really used (albeit not on linux)
the unused.easy thing is parsing a linux build... so there may be some
false positive there...
SO I would suggest smaller patch (rebuilding should not be that
painfull, if you stay on the same position on master and just do
incremental build...
Norbert
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.