On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote:
On 10/16/2012 11:14 AM, d.ostrovsky@idaia.de wrote:
Quoting David Tardon <dtardon@redhat.com>:
Basically it seems that in the command:
"cp $W/Extension/report-builder/root"
it's missing the first operand....
It is a use case that nobody has ever tried before, because en-US is the
default language. The line comes from solenv/gbuild/ExtensionTarget.mk
and the missing argument(s) is a list of files based on $(gb_WITH_LANG),
but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US
in your case, there are no files to copy...
the easiest way to sort this out would be to add a check in configure.in
for that:
if --with-lang="en-US" then fail or unset WITH_LANG, right?
No, the easiest thing should be to fix
solenv/gbuild/ExtensionTarget.mk. I understand that the other David
is doing that.
Maybe not the easiest, but the most correct :-)
diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk
index 91f1be3..eb45785 100644
--- a/solenv/gbuild/ExtensionTarget.mk
+++ b/solenv/gbuild/ExtensionTarget.mk
@@ -112,7 +112,7 @@ $(call gb_ExtensionTarget_get_target,%) : \
$(call gb_ExtensionTarget__subst_platform,$(call
gb_ExtensionTarget_get_workdir,$*)/description.xml,$(call gb_ExtensionTar
$(call gb_ExtensionTarget__subst_platform,$(LOCATION)/manifest.xml,$(call
gb_ExtensionTarget_get_rootdir,$*)/META-INF/mani
$(if $(LICENSE),cp -f $(LICENSE) $(call
gb_ExtensionTarget_get_rootdir,$*)/registration &&) \
- $(if $(and $(gb_WITH_LANG),$(DESCRIPTION)),cp $(foreach
lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb_ExtensionTarget_g
+ $(if $(and $(gb_ExtensionTarget_TRANS_LANGS),$(DESCRIPTION)),cp $(foreach
lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb
cd $(call gb_ExtensionTarget_get_rootdir,$*) && \
$(gb_ExtensionTarget_ZIPCOMMAND) -rX --filesync \
$(call gb_ExtensionTarget_get_target,$*) \