Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

Quoting David Tardon <dtardon@redhat.com>:

Hi,

On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote:
On 10/16/2012 11:14 AM, d.ostrovsky@idaia.de wrote:
>the easiest way to sort this out would be to add a check in configure.in
>for that:
>if --with-lang="en-US" then fail or unset WITH_LANG, right?

No, the easiest thing should be to fix
solenv/gbuild/ExtensionTarget.mk.  I understand that the other David
is doing that.

Maybe not the easiest, but the most correct :-)
;-)
ah, well, if we are talking about the correct way ...
then we shouldn't play these games with such a construct
MODULE_FOO_LANGS := en-US $(filter-out en-US,$(gb_WITH_LANG))
any more but introduce a new variable gb_WITH_LANG_OR_DEFAULT
and use it in all places instead.

I mentioned it already in comment in readlicense_oo module during gbuildification ...
but didn't do it myself ;-)

http://cgit.freedesktop.org/libreoffice/core/tree/readlicense_oo/CustomTarget_readme.mk#n15

Regards
David


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.