Re: [REVIEW 3-6 3-6-3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Sat, 13 Oct 2012 20:43:30 +0200

Hey,

2012/10/13 Kohei Yoshida <kohei.yoshida@gmail.com>:

On Sat, Oct 13, 2012 at 1:22 AM, Markus Mohrhard
<markus.mohrhard@googlemail.com> wrote:

Yeap, my mistake. It misses the -nStartRow or -nStartCol that makes
the nRow/nCol relative to the deleted column/row.

I attached a patch that squashs both necessary commits into one.


Yup. That looks more like it. Pushed it to 3-6 with my sign-off.
We'll need to work on adding a test case for this later (on master)...


I already have a test case which is just in my unpushed patch queue.

Markus

Context

[REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
- Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Kohei Yoshida
  - Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
    - Re: [REVIEW 3-6 3-6-3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Kohei Yoshida
      - Re: [REVIEW 3-6 3-6-3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
      - Re: [REVIEW 3-6-3 2/3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Eike Rathke
        
        Re: [REVIEW 3-6-3 2/3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Noel Power
        
        Re: [PUSHED 3-6][PUSHED 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.