Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells

Kohei Yoshida <kohei.yoshida -AT- gmail.com>
Sat, 13 Oct 2012 00:51:58 -0400

On 10/12/2012 10:46 PM, Markus Mohrhard wrote:

Hey,

[1] prevents to insert notes to deleted cells. These notes have than
negative col or row numbers so they produce a crash in the export
code.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ec03fc221e80479557f05f53972ca864f1ff4bb


It appears there is a bug in this code.

Try this scenario.

1) Insert a node at row 12.

2) Select rows 10-14, and Delete Row.

3) Scroll out and back in to repaint.

4) Now you see the note at row 7, but the note should have been deleted.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context

[REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
- Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Kohei Yoshida
  - Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
    - Re: [REVIEW 3-6 3-6-3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Kohei Yoshida
      - Re: [REVIEW 3-6 3-6-3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Markus Mohrhard
      - Re: [REVIEW 3-6-3 2/3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Eike Rathke
        
        Re: [REVIEW 3-6-3 2/3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells · Noel Power
        
        Re: [PUSHED 3-6][PUSHED 3-6-3] fix for fdo#55885, don't insert notes to deleted cells · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.