Re: [REVIEW 3-6 3-6-3] fix for fdo#55885, don't insert notes to deleted cells

Hey,

> > [1] prevents to insert notes to deleted cells. These notes have than
> > negative col or row numbers so they produce a crash in the export
> > code.
> >
> > Regards,
> > Markus
> >
> > [1]
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ec03fc221e80479557f05f53972ca864f1ff4bb
>
>
> It appears there is a bug in this code.
>
> Try this scenario.
>
> 1) Insert a node at row 12.
>
> 2) Select rows 10-14, and Delete Row.
>
> 3) Scroll out and back in to repaint.
>
> 4) Now you see the note at row 7, but the note should have been deleted.

Yeap, my mistake. It misses the -nStartRow or -nStartCol that makes
the nRow/nCol relative to the deleted column/row.

I attached a patch that squashs both necessary commits into one.

Regards,
Markus

Attachment: 0001-don-t-insert-notes-from-deleted-cells-fdo-55885.patch
Description: Binary data