Quoting "Norbert Thiebaud (via Code Review)" <gerrit@gerrit.libreoffice.org>:
Norbert Thiebaud has posted comments on this change.
Change subject: WORK IN PROGRESS gbuildification of jfreereport
......................................................................
Patch Set 1:
please to not use 'WORK IN PROGRESS' in the commit title
use a review -1/-2 + appropriate comment instead to indicate that
ditto for the TODO section is the commit message body
the risk here is that this kind of less than helpfull commit title
end-up in the git repo... fixing the code is a matter of another
patch.. but fixing the commit message of a commit after it has been
push is not an option
as already discussed on IRC is review -1/-2 completely wrong here
(well from my point of view!).
Actualy gerrit is missing that WORK IN PROGRESS (WIP) feature.
With Draft no one can see it unless you add reviewer explicitly.
With WIP you want visibility, (possibly) earlier feedback and even
tinderbox checks.
In fact if you think gerit is lack some feature, then first thing to check is
what the gerrit's power users did - openstack project:
open stack guys patched gerrit and added WIP feature to it!
We should probably just pick their gerrit version:
WIP patch, but still checked by CI Server:
https://review.openstack.org/#/c/14002/
WIP why: http://wiki.openstack.org/GerritWorkflow
[...]
If your code is not ready for review, click "Work in Progress" to
indicate that
a reviewer does not need to review it for now. Note that the button is
invisible
until you login the site.
WIP how: https://bugs.launchpad.net/openstack-ci/+bug/902953
WIP where:
https://github.com/openstack-ci/gerrit/commit/4212f6cb052661b7b36f7777e28e2776c1d769aa
Regards
David
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.