Hi Noel,
On Wed, 2012-10-03 at 10:15 +0100, Noel Power wrote:
please consider this patch
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fdb42c397f1d15d05a74492a233df72d832cab1c
Pushed; IIRC using:
- if ( aProps[ i ].Name.equals( "TextPreRotateAngle" ) ..
+ if ( aProps[ i ].Name == "TextPreRotateAngle" ...
Is more efficient (by the power of Lubos' cunning), avoiding a dynamic
allocation, and a couple of atomic operations each comparison. Though
perhaps I remember wrong.
If that's right, would it make sense to have an easy-hack to go over
all re-based modules hunting and replacing .equals with == ?
$ git grep 'equals(' | grep \.cxx | less
Or am I loosing it ;-)
ATB,
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.