Re: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import

Stephan Bergmann <sbergman -AT- redhat.com>
Wed, 01 Aug 2012 18:17:12 +0200

On 08/01/2012 03:29 PM, Michael Meeks wrote:

        That aside - I've never been a big fan of the "crash on bad input" mode
of OUString::copy() that seems incredibly lame to me. Is there any
convincing performance reason that anyone can work out for not just
returning an empty string in these cases ? ie. create a new rtl _copy
method that does the checking out-of-line in the method: I wonder how
common the case of copy() a full string is that we in-line the check for
that.

make rtl::OUString::copy(beginIndex, count) clip to [0..length)? yeah,why not (then again, -1's sentinel nature, cf. indexOf, might mean thatsilent clipping of beginIndex=-1 to beginIndex=0 is unfortunate)


Stephan

Context

[REVIEW 3-6] resolved fdo#53012 crash in CSV fixed width import · Eike Rathke
- [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import · Michael Meeks
  - Re: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import · Stephan Bergmann
    - make OUString::copy() clip (was: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import) · Eike Rathke
      - Re: make OUString::copy() clip · Michael Stahl
        
        Re: make OUString::copy() clip · Eike Rathke
        
        Re: make OUString::copy() clip · Stephan Bergmann
        
        Re: make OUString::copy() clip · Noel Grandin
        Re: make OUString::copy() clip · Stephan Bergmann
- Re: [PUSHED][REVIEW 3-6] resolved fdo#53012 crash in CSV fixed width import · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.