Re: make OUString::copy() clip

Stephan Bergmann <sbergman -AT- redhat.com>
Thu, 02 Aug 2012 14:42:57 +0200

On 08/02/2012 02:39 PM, Noel Grandin wrote:

On 2012-08-02 14:35, Stephan Bergmann wrote:

No "defensive programming," please.  If we consider a given
(beginIndex, count) arguments a violation of copy's precondition, then
fail on it, as fast as possible (via assert -> abort in a non-NDEBUG
build, via undefined behavior (-> hopefully crash soon) otherwise).

Rather crash earlier than later.
   *NULL = 0xdeadbeef;
can't be all that expensive.


Then rather -UNDEBUG.  Can't be all that expensive, either.

Stephan

Context

[REVIEW 3-6] resolved fdo#53012 crash in CSV fixed width import · Eike Rathke
- [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import · Michael Meeks
  - Re: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import · Stephan Bergmann
    - make OUString::copy() clip (was: [PUSHED 3-6] resolved fdo#53012 crash in CSV fixed width import) · Eike Rathke
      - Re: make OUString::copy() clip · Michael Stahl
        
        Re: make OUString::copy() clip · Eike Rathke
        
        Re: make OUString::copy() clip · Stephan Bergmann
        
        Re: make OUString::copy() clip · Noel Grandin
        Re: make OUString::copy() clip · Stephan Bergmann
- Re: [PUSHED][REVIEW 3-6] resolved fdo#53012 crash in CSV fixed width import · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.