Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hello Stefan, Michael,

yes a throbber is used in the extension manager.

See:
http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatehdl.cxx#1328
http://opengrok.libreoffice.org/xref/core/toolkit/source/controls/spinningprogress.cxx#77

I've attached a list of all spinner files in the source tree (find . -name spinner*).

spinner03-grey-... is referenced in xthrobber.src (toolkit/source/awt/xthrobber.src). And xtrobber.src appears in AllLangResTarget_tk.mk and src.lst.

Those spinner files in throbber.src (spinner-*) only exist for the galaxy theme. This is curious.
For example: ./icon-themes/galaxy/shared/spinner-16-01.png
Implies the path shared that these files are shared over all icon themes? But there are no more files than the spinner files in this directory. And this would also imply, that the galaxy theme is a requirement for all installations.

But there is another problem: throbber.src is not in AllLangResTarget_tk.mk nor src.lst - so unknown and unused. Despite the fact, that SpinningProgressControlModel uses Throbber::getDefaultImageURLs where those spinner files are used.

As said before: There is no difference for me with and without throbber.src in the images.zip. I've did the build from clean now. And also looked at the binary libo 3.5.4 from the website (Linux). There are only spinner03-grey_* (files from xthrobber.src) in the zips. Like this:

libobasis3.5-images_3.5.4-2_i386/opt/libreoffice3.5/share/config/images/toolkit/tk/spinner03-grey_01.png

No other ones.

So is this a bug or is are those spinner-* from throbber.src obsolete? This would also mean, that Throbber::getDefaultImageURLs is obsolete and so on.

Thomas


On Tue, 03 Jul 2012 19:26:35 +0200, Stefan Knorr wrote:
Hello Thomas, Michael,

AFAIK, LibO uses a throbber in its extension manager, e.g. when looking
for extension updates. I believe the application update checker also
uses a throbber.
I can't really say if that's the one you are trying to remove (I think
there were multiple throbber directories)... but, as Michael says,
images.zip tends to become stale on subsequent builds.

Stefan.
find . -name spinner*
./icon-themes/human/toolkit/source/awt/spinner03-grey_07.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_04.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_06.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_08.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_01.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_02.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_05.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_11.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_10.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_03.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_12.png
./icon-themes/human/toolkit/source/awt/spinner03-grey_09.png
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_07.png
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_04.png
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_06.png
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_08.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_01.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_02.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_05.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_11.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_10.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_03.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_12.png                                       
                                 
./icon-themes/oxygen/toolkit/source/awt/spinner03-grey_09.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_07.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_04.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_06.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_08.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_01.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_02.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_05.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_11.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_10.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_03.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_12.png                                       
                                 
./icon-themes/hicontrast/vcl/source/src/spinner03-grey_09.png                                       
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_07.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_04.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_06.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_08.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_01.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_02.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_05.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_11.png                                           
                                 
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_10.png
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_03.png
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_12.png
./icon-themes/hicontrast/toolkit/tk/spinner03-grey_09.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-06.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-11.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-10.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-05.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-09.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-03.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-05.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-05.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-03.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-04.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-07.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-08.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-04.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-02.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-04.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-11.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-02.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-01.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-12.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-01.png
./icon-themes/galaxy/hicontrast/shared/spinner-16-06.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-07.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-08.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-12.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-10.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-03.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-06.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-02.png
./icon-themes/galaxy/hicontrast/shared/spinner-64-01.png
./icon-themes/galaxy/hicontrast/shared/spinner-32-09.png
./icon-themes/galaxy/shared/spinner-64-06.png
./icon-themes/galaxy/shared/spinner-32-11.png
./icon-themes/galaxy/shared/spinner-32-10.png
./icon-themes/galaxy/shared/spinner-64-05.png
./icon-themes/galaxy/shared/spinner-64-09.png
./icon-themes/galaxy/shared/spinner-16-03.png
./icon-themes/galaxy/shared/spinner-16-05.png
./icon-themes/galaxy/shared/spinner-32-05.png
./icon-themes/galaxy/shared/spinner-32-03.png
./icon-themes/galaxy/shared/spinner-32-04.png
./icon-themes/galaxy/shared/spinner-64-07.png
./icon-themes/galaxy/shared/spinner-32-08.png
./icon-themes/galaxy/shared/spinner-16-04.png
./icon-themes/galaxy/shared/spinner-16-02.png
./icon-themes/galaxy/shared/spinner-64-04.png
./icon-themes/galaxy/shared/spinner-64-11.png
./icon-themes/galaxy/shared/spinner-64-02.png
./icon-themes/galaxy/shared/spinner-32-01.png
./icon-themes/galaxy/shared/spinner-32-12.png
./icon-themes/galaxy/shared/spinner-16-01.png
./icon-themes/galaxy/shared/spinner-16-06.png
./icon-themes/galaxy/shared/spinner-32-07.png
./icon-themes/galaxy/shared/spinner-64-08.png
./icon-themes/galaxy/shared/spinner-64-12.png
./icon-themes/galaxy/shared/spinner-64-10.png
./icon-themes/galaxy/shared/spinner-64-03.png
./icon-themes/galaxy/shared/spinner-32-06.png
./icon-themes/galaxy/shared/spinner-32-02.png
./icon-themes/galaxy/shared/spinner-64-01.png
./icon-themes/galaxy/shared/spinner-32-09.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_07.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_04.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_06.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_08.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_01.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_02.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_05.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_11.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_10.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_03.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_12.png
./icon-themes/galaxy/toolkit/tk/spinner03-grey_09.png

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.