Re: [PUSHED][PATCH] Prevent print settings dialog to show help button when it's called from help window

Caolán McNamara <caolanm -AT- redhat.com>
Tue, 26 Jun 2012 15:59:28 +0100

On Tue, 2012-06-26 at 15:06 +0200, Maxime de Roucy wrote:

Here is the a new 0003 and 0004 without the bug.


ok, so pushed 3 and 4 to master now. Thanks for this.

It seems odd that we have *two* methods in SfxPrinter, IsKnown and
IsOriginal that both return bKnown and are so equivalent. Maybe we
should delete one of the blasted things.

The original detection of being called from an API call was odd, esp
with the rollback of "i'm from the api if i have parameters, except if i
have one parameter and it's print-selection". So to me pre 3 and post 3
*seem* equivalent except for the addition of the new property, but its a
bit of a rats nest of code :-)

C.

Context

[Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window · Maxime de Roucy
- Re: [Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window · Maxime de Roucy
- Re: [PUSHED partial][PATCH] Prevent print settings dialog to show help button when it's called from help window · Caolán McNamara
  - Re: [PUSHED partial][PATCH] Prevent print settings dialog to show help button when it's called from help window · Maxime de Roucy
    - Re: [PUSHED][PATCH] Prevent print settings dialog to show help button when it's called from help window · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.