Re: [PUSHED partial][PATCH] Prevent print settings dialog to show help button when it's called from help window

On Tue, 2012-06-19 at 16:05 +0200, Maxime de Roucy wrote:
> Hello,
>
> Here is some patchs :
> 0001 : one line, code simplification.

I've pushed this one anyway.

> 0002 : explicite NULL or 0 comparison in if. I don't know if LibreOffice
> have a coding standard about that type of comparison ?

meh, I don't think we have any coding standards around it. But I'd skip
this one as in the absence of a coding standard I don't see the value in
swapping from one equally valid syntax to another.

> 0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some
> comments, prevent a segfault (NULL pointer dereferencing ; add return
> after "rReq.SetReturnValue(SfxBoolItem(0,sal_False))"
> 0004 : Prevent the printer settings dialog to show help button when it's
> called from a help window.

I guess we'll leave the other two until your updated patches. Right ?,
or is 0004 still valid ?

C.