Re: [Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window

The patch 0003 introduce a bug :
-            if ( SID_PRINTER_NAME == nId )
-            {
-                // just set a recorded printer name
-                if ( pPrinter )
-                    SetPrinter( pPrinter, SFX_PRINTER_PRINTER  );
-                break;
-            }

please wait before pushing it.
I will release a patch that will correct the problem.

Regards

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0033(0)642004909


Le mardi 19 juin 2012 à 16:05 +0200, Maxime de Roucy a écrit :
> Hello,
>
> Here is some patchs :
> 0001 : one line, code simplification.
> 0002 : explicite NULL or 0 comparison in if. I don't know if LibreOffice
> have a coding standard about that type of comparison ?
> 0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some
> comments, prevent a segfault (NULL pointer dereferencing ; add return
> after "rReq.SetReturnValue(SfxBoolItem(0,sal_False))")…
> 0004 : Prevent the printer settings dialog to show help button when it's
> called from a help window.
>
> Regards.
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

Attachment: signature.asc
Description: This is a digitally signed message part