Re: [REVIEW:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

+1 from me for 3.5.4

F.

On 21/05/12 16:08, Petr Mladek wrote:
> Christian Lohmaier píše v So 19. 05. 2012 v 14:12 +0200:
> > Hi *,
> >
> > please review and pick for 3.5 & 3.5.4 if possible. It is Mac PPC
> > only, and no change of the logic of the code, but just reordering to
> > avoid padding of elements in two structs in libjpeg.
> >
> > bug:
> > https://bugs.freedesktop.org/show_bug.cgi?id=47035
> >
> > changes:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a27a3990b8bbfa8924d2b55c38ceab7c9049ea6d
> >
> > and
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8ecb8801f4330c2d2da88b992e2039e020d4fa4
> >
> > The padding is the cause of a regression compared to LO 3.4.x that
> > makes it impossible to open/insert and jpeg images.
> >
> > When trying to open/save a jpeg on Mac/PPC one gets a "Graphic filter
> > not found" message
>
> Great catch! I can't test it myself on MAC but I believe that you did
> it. The patch makes sense => pushed into 3-5 branch, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=efdd08cf8985c0b322ef94f62877caa5c4b3694d
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a220ec769d6489df7f3dd01cf25ea59dfd793276
>
> We need two more approvals for 3-5-4.
>
>
> Best Regards,
> Petr
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice