Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Christian Lohmaier píše v So 19. 05. 2012 v 14:12 +0200:
Hi *,

please review and pick for 3.5 & 3.5.4 if possible. It is Mac PPC
only, and no change of the logic of the code, but just reordering to
avoid padding of elements in two structs in libjpeg.

bug:
https://bugs.freedesktop.org/show_bug.cgi?id=47035

changes:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a27a3990b8bbfa8924d2b55c38ceab7c9049ea6d

and

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8ecb8801f4330c2d2da88b992e2039e020d4fa4

The padding is the cause of a regression compared to LO 3.4.x that
makes it impossible to open/insert and jpeg images.

When trying to open/save a jpeg on Mac/PPC one gets a "Graphic filter
not found" message

Great catch! I can't test it myself on MAC but I believe that you did
it. The patch makes sense => pushed into 3-5 branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=efdd08cf8985c0b322ef94f62877caa5c4b3694d
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a220ec769d6489df7f3dd01cf25ea59dfd793276

We need two more approvals for 3-5-4.


Best Regards,
Petr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.