Hi Noel, On Tuesday, 2012-05-08 06:10:01 -0600, Noel Power wrote:
I tried with 3.4.5 and there the objects are imported to the correct row and also survive save/reload (except that row heights are saved wrongly also there),oh :-/ now that is strange 'cause the problem ( xlsx import ) was originally reported against 3.4.x, I tacked on the xls support as I saw the same position misbehaviour in 3.5. So... it seems at least from what you are saying that something nasty has happened with xls import post 3.4
Yup, I only tried with the .xls file that worked fine in 3.4.5 But as seen on IRC you found what's going wrong where...
I'm hesitating to push your patch because it changes behavior such that after import it looks ok but saving messes things up so may go unnoticed. Before at least it was clearly visible that something's wrong ;-)hmm, not sure I totally agree, but how about just enabling this for oox import then, I think that in all cases there is an improvement with that right ? would that be ok?Would be good if you could find the cause of the jumping around when saving/reloading, and why row heights aren't saved properly.looks like row heights were broken for some time, just at this minute that's less critical ( and not sure even where to start look for that ) I hope to try and find out why the xls import/export causes such grief now first.
I'm still hoping you'll find the real fix ;-) Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
pgpkyPqOKc2S2.pgp
Description: PGP signature