Hey Daniel,
So I don't need to add more test cases to the spreadsheet and csv?
No that is fine for the beginning. The idea is that we add more test
cases if we see corner cases in the code. Then we should add a test
case before we refactor that part of the code. I think with the cell
import covered by a test you can finally work on moving the xlsx cell
import from uno calls to direct calls.
Also, I noticed that ScFiltersTest::testSharedFormulaXLSX() in
sc/qa/unit/subsequent_filters-test.cxx looks like it may be missing
xDocSh->DoClose() at the end. Since you've pushed to the master, this would
be after line 680. I would have made the change myself, but I didn't know
if it was appropriate.
Good catch. Pushed a fix to master.
Regards,
Markus
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.