Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines)

Petr Mladek <pmladek -AT- suse.cz>
Mon, 26 Mar 2012 21:02:02 +0200

Michael Stahl píše v Pá 23. 03. 2012 v 17:44 +0100:

because up until a week ago my knowledge of Writer's drawing code was
precisely zero, it would be a good idea to test this a bit.  in case
something is still wrong i'd strongly consider reverting the original
commit (0f0896c26fb260d1bbf31d7a886df3f61837f0f2).


Cedric found a problem with it, so we should revert:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-2&id=c7524ab32f801910673da5c9c68669ada7c98769
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-2&id=0f0896c26fb260d1bbf31d7a886df3f61837f0f2

Hmm, the second (and original) commit is pretty old and there are 6
conflicts and 7 fuzzy hunks. I do not have power to dig into this during
this late hour :-(


Best Regards,
Petr

Context

Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines (continued)
- Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines · Cedric Bosdonnat
  - [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines) · Michael Stahl
    - Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions · Cor Nouws
      - Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions · Cor Nouws
    - Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines) · Cedric Bosdonnat
      - [REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions · Michael Stahl
        
        Re: [REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions · Caolán McNamara
        
        Re: [REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions · Michael Stahl
        
        Re: [PUSHED 3-5][REVIEW 3-5] [REVIEW 3-5-3] fdo#47717, fdo#45562 sw: yet more border painting regressions · Caolán McNamara
        Re: [PUSHED: 3-5, 3-5-3] fdo#47717, fdo#45562 sw: yet more border painting regressions · Petr Mladek
    - Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines) · Petr Mladek
    - Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines) · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.