On Sat, Mar 24, 2012 at 5:00 PM, Matúš Kukan <matus.kukan@gmail.com> wrote:
On 20 March 2012 21:04, Matúš Kukan <matus.kukan@gmail.com> wrote:
On 20 March 2012 11:17, Michael Stahl <mstahl@redhat.com> wrote:
but please rename the CDPI variable to packimages_CDPI or expand it
(also, CUSTOM_images, CUSTOM_PREFERRED_FALLBACK_[12])
CDPI was supposed to be custom-target-directory-packimages.
That's not good because CD would be the same for all custom targets,
but 3(4) letters should be enough? First two for <module> and third
(or also fourth) for directory in module.
It must be enough to avoid collision, we don't have so many modules.
I decided to use 4 letters and push my patches(*) because i18npool was wrong
and after --disable-dependency-tracking change in gbuild it started to fail.
We still can change the makefiles in case something is wrong or should
be done better.
Matus
(*)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1140c380ad15648def3fc7a71d735a46ed4289d9
http://cgit.freedesktop.org/libreoffice/core/commit/?id=15bd35e4f2646ef0bba0cc24d171989c9e3ac6e4
That seems to break my windows build, which now abend on the
invocation of saxparser
Norbert
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.