Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Tue, 2012-03-20 at 21:26 +0100, Chr. Rossmanith wrote:
A PresenterAnimation could be instantiated here

     ModeChangeAnimation (
         const ::boost::shared_ptr<PresenterSprite>& rpSprite,
         const Reference<rendering::XSpriteCanvas>& rxCanvas)
         : PresenterAnimation (0, 1000, 20),
           mpSprite(rpSprite),
           mxCanvas(rxCanvas)
     {
     }

in PresenterWindowManager.cxx - iff ModeChangeAnimation would be used 
anywhere. I can't find any place where it is used. Double check would be 
nice. So first ModeChangeAnimation would have to go, then 
PresenterAnimation could be removed as well.

Yup, callcatcher is correct here. ModeChangeAnimation itself is all
inlines and itself is never instantiated so gcc doesn't even emit any
ModeChangeAnimation code, so both it and PresenterAnimation can go. 

I'd actually ModeChangeAnimation chopped out here locally, I've pushed
that now with the last unused-code update

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.