On Sat, 2012-03-17 at 15:34 +0100, Chr. Rossmanith wrote:
Hi,
I had a look at unusedcode.easy (sdext/presenter) and removed a little
bit more than mentioned there: as there are no end callbacks added
(AddEndCallback() was unused), there is no need to run them ->
RunEndCallbacks() could be removed as well. Same logic for start
callbacks. Finally mpStartCallbacks and mpEndCallbacks could leave, too.
Yup, I agree, I pushed this now.
In PresenterAnimator AddAnimation() was unused and it seems that the
whole class might be removed?!?
Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator
ctor is never called, and its the only constructor, so one is never
instantiated, so you can remove the whole thing without loss of
functionality.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.