Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


though it was too late for 3-5-1 but apparently not so changing subject to reflect review status, thanks to Kohei just one review needed

Noel
On 28/02/12 01:22, Kohei Yoshida wrote:
On Sat, 2012-02-25 at 18:36 +0100, Markus Mohrhard wrote:
Hello Noel,

2012/2/24 Noel Power<nopower@suse.com>:
please review the patch from master here, the detail ( valgrind and gdb
traces etc. ) already in the bug so I won't duplicate here
http://cgit.freedesktop.org/libreoffice/core/commit/?id=22871f1af3be444e747f7adaad5221b9c8b0bebf

This looks correct. It is a mistake by me that I did not think about
the UpdateCheck which will erase pData in parallel if one of the
checkboxes is modified.

Maybe the correct fix for master is to create an own handler for the
check boxes that will not erase the the range name but will think a
bit about it.
I'll give my sign-off for 3.5.1.  This is a trivial change that prevents
a crash.

One more needed to push this to the 3-5-1 branch.

Kohei



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.