Re: [REVIEW 3-5][PUSHED] fdo#46568 - VALGRIND corruption

On Sat, 2012-02-25 at 18:36 +0100, Markus Mohrhard wrote:
> Hello Noel,
>
> 2012/2/24 Noel Power <nopower@suse.com>:
> > please review the patch from master here, the detail ( valgrind and gdb
> > traces etc. ) already in the bug so I won't duplicate here
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=22871f1af3be444e747f7adaad5221b9c8b0bebf
>
> This looks correct. It is a mistake by me that I did not think about
> the UpdateCheck which will erase pData in parallel if one of the
> checkboxes is modified.
>
> Maybe the correct fix for master is to create an own handler for the
> check boxes that will not erase the the range name but will think a
> bit about it.

I'll give my sign-off for 3.5.1.  This is a trivial change that prevents
a crash.

One more needed to push this to the 3-5-1 branch.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc