Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

On 02/02/12 18:17, Muhammad Haggag wrote:
> On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag <mhaggag@gmail.com 
> <mailto:mhaggag@gmail.com>> wrote:
>
>     On Thu, Feb 2, 2012 at 2:01 PM, Noel Power <nopower@suse.com
>     <mailto:nopower@suse.com>> wrote:
>
>         very nice patch, looking at the spec I agree and this looks
>         like a credible fix for me so pushed to master. Look forward
>         to more like this, thanks
>
>     Thanks for the review! If you'd pardon my absolute noobiness, do I
>     have access to push to master? I checked out the code from the
>     anongit repository.
>
>
> Ah, disregard my question--I thought you were asking me to push. Now I 
> see that you were saying you've already pushed it. Another question 
> though, what to do about the bug? Will you resolve or close it, or 
> should I do that? Or is it the tester(s)?
> Regards,
> --Muhammad
sorry, missed this mail, I marked it as fixed, I am not sure about the 
'hard' rules about resolving a bug, generally I mark my own bugs as 
resolved after I commit a fix and/or test. I think if someone reviews a 
patch ( that is addresses a specific bug ) then they probably should 
mark the bug as well after they commit the patch ( and I forgot to do 
that ;-) )

thanks again

Noel