Re: [LibreOffice] [Bug 39428] audit / remove SvStream long operators

On Wed, Feb 1, 2012 at 3:09 PM, <bugzilla-daemon@freedesktop.org> wrote:

> https://bugs.freedesktop.org/show_bug.cgi?id=39428
>
> --- Comment #9 from Caolán McNamara <caolanm@redhat.com> 2012-02-01
> 07:09:32 PST ---
> here's one place I know about where the current std::stream-alike "failed
> reads
> leave the original value untouched" is relied upon
>
> sw/source/filter/ww8/ww8san.cxx
>    while( 1 )
>    {
>        sal_uInt8 clxt(2);
>        *pStr >> clxt; //if read fails, then value remains 2, so loop breaks
> even on failure
>        nLeft--;
>        if( 2 == clxt )
>            break;
>        ...
>     }
>
> Sorry for the delay in replying. I have changed the return types from
Stream& to be the same as the parameter type and a return of 0 indicates
failure. Currently working through tools/
As this is quite a large change, should I submit patches as I complete the
various sub-projects?

Cheers