Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index



First marking this as pushed ( as I pushed this but forgot to mark it as so )
On 04/02/12 16:00, Michael Stahl wrote:
[...]
hi Noel,

a further improvement would be to replace boost::ptr_vector with
std::vector: our various String classes (at least the 4 most popular
ones) effectively are already smart pointers to an array and can be
stored directly in STL containers, so wrapping them in _another_ pointer
is just, errm, pointless
I suppose you save lots of String copies but.... presumably if the String implementation really is 'smart' ( which iirc it is ) then it only points to the existing string and doesn't actually create a 'new' copy of that. I wonder why the orig implementation didn't store objects ( or didn't List ever support that ) or was it influenced by a heap vs stack concern ( that probably is irrelevant these days ) Anyway, won't do any harm leaving it as it is or perhaps someone will go the extra step and change it.

Noel

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.