Re: [Libreoffice] [REVIEW] Revert of UNO interface publishing

On Thu, Jan 26, 2012 at 10:24:52PM +0100, Thorsten Behrens wrote:
> Michael Meeks wrote:
> > AA:  + do the easiest roll-back possible to cleanup the
> >        canvas publishing issue in 3.5.0 (Thorsten)

> Anyway - commit on master is here:

>  http://cgit.freedesktop.org/libreoffice/core/commit/?id=78cca63070ae6cf82b45ec3bc75fafa2db31a7f2

I'd have preferred if you just removed the "published" tag and did not
also remove documentation-in-comment, as in:

diff --git a/offapi/com/sun/star/frame/XTitle.idl
b/offapi/com/sun/star/frame/XTitle.idl
index d93c25b..59b82e8 100644
--- a/offapi/com/sun/star/frame/XTitle.idl
+++ b/offapi/com/sun/star/frame/XTitle.idl
@@ -36,23 +36,17 @@
module com { module sun { module star { module frame {
//=============================================================================
-/** an interface representing an entity with a modifyable title.
+/** todo document me
*/
-published interface XTitle : com::sun::star::uno::XInterface
+interface XTitle : com::sun::star::uno::XInterface
{
//-------------------------------------------------------------------------
- /** Returns the title of the object.
- *
- * @returns
- * The title.
+ /** todo document me
*/
string getTitle ();
//-------------------------------------------------------------------------
- /** Sets the title of the object.
- *
- * @param sTitle
- * The title.
+ /** todo document me
*/
void setTitle ( [in] string sTitle );
};


Also, what is the point of

--- a/offapi/com/sun/star/rendering/StrokeAttributes.idl
+++ b/offapi/com/sun/star/rendering/StrokeAttributes.idl
@@ -28,6 +28,14 @@
#ifndef __com_sun_star_rendering_StrokeAttributes_idl__
#define __com_sun_star_rendering_StrokeAttributes_idl__
+#ifndef __com_sun_star_rendering_PathCapType_idl__
+#include <com/sun/star/rendering/PathCapType.idl>
+#endif
+#ifndef __com_sun_star_rendering_PathJoinType_idl__
+#include <com/sun/star/rendering/PathJoinType.idl>
+#endif
+
+
module com { module sun { module star { module rendering {
/** This structure contains all attributes required for path stroking.<p>


and of


--- a/offapi/com/sun/star/rendering/XBitmap.idl
+++ b/offapi/com/sun/star/rendering/XBitmap.idl
@@ -36,6 +36,8 @@
module com { module sun { module star { module rendering {
+interface XBitmapCanvas;
+
/** This is a generic interface to a bitmap.<p>
This interface contains the generic functionality to be used on

-- 
Lionel