Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

Stephan Bergmann <sbergman -AT- redhat.com>
Wed, 25 Jan 2012 08:50:44 +0100

On 01/24/2012 10:32 PM, Christina Roßmanith wrote:

Could someone please review it? It builds successfully but I'm unsure
about where to use "const"...

In short, marking a member function const can (and should) be donewhenever the function does not modify its object, and does not itselfcall any other functions that would do (i.e., only calls other memberfunctions that are also const).

From looking at the patch, OutputDevice::ImplDrawModeToColor couldprobably be made const, unless any of the other functions it calls(GetDrawMode, GetSettings, ImplIsColorTransparent) is a non-const memberfunction of OutputDevice. Generally, the compiler tells one if onedeclared a function const that can technically not be const.


Stephan

Context

[Libreoffice] [PATCH] Reduced duplicate code detected by simian · Christina Roßmanith
- Re: [Libreoffice] [Pushed] [PATCH] Reduced duplicate code detected by simian · Muthu Subramanian K
- Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian · Stephan Bergmann
- Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.