Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

Eike Rathke <erack -AT- redhat.com>
Thu, 26 Jan 2012 21:27:41 +0100

Hi Christina,

Nice find. Just to mention that this

+    SAL_DLLPRIVATE Color ImplDrawModeToColor( Color );
+Color OutputDevice::ImplDrawModeToColor( const Color rColor )


not only should be a const method as Stephan mentioned, but also should
get passed a   const Color& rColor   reference instead, otherwise an
unnecessary temporary copy of the Color object would be created as
argument. Muthu already changed that in the commit.

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpNtuEdZuzBT.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH] Reduced duplicate code detected by simian · Christina Roßmanith
- Re: [Libreoffice] [Pushed] [PATCH] Reduced duplicate code detected by simian · Muthu Subramanian K
- Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian · Stephan Bergmann
- Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.