Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

Am 12.01.2012 17:17, schrieb Olivier Hallot:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Thank you Christina for the patch.
>
> It look like your patch is ok, with respect to the logic inversion. A
> build should indicate if the method isEmpty() is valid for the right
> object (e.g. it is not valid for OUStringBuffer or Sequence).
I've built it successfully and found out that O(U)StringBuffer has no 
isEmpty() this morning  :-)
> Do you mind to
> 1) update bug fdo43460 with your (pushed) patch?
You mean just add an comment which mentions the directory I've been 
working in? Of course can I do that. When I'm finished with vcl or 
already now with that little bit?
> 2) complete module vcl/ with these replacements? I will mark it as yours
> in my control file. Attached an exerpt of the files and lines to look at.
As time permits. Probably interleaved with the ByteString replacement.

Christina

> Regards
>
> Olivier
>
>
> Em 12-01-2012 12:29, Chr. Rossmanith escreveu:
> > Hi,
> >
> > while replacing ByteString with OString I came across some getLength()
> > calls which might be replaced with isEmpty(). Hope Olivier won't be
> > annoyed  :-)
> >
> > Some reviewing would be nice to be sure the logic didn't get inverted
> > accidently.I have git push access - so reviewing would be sufficient.
> >
> > Christina
> >
> >
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> - -- 
> Olivier Hallot
> Founder, Board of Directors Member - The Document Foundation
> LibreOffice translation leader for Brazilian Portuguese
> +55-21-8822-8812
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJPDwehAAoJEJp3R7nH3vLxl3cH/0qtyGFDI44WaSWr5XVKgU7n
> oGzqcz/DBAuaDRr7NZnHp2rerAXNur1r6M1gVL+yyO/DsLxwnDdUAQsUdwcZspzR
> zckK5D8l9q6oD/+o16Ismr5/r+E9Fn5Jz/MH+ER+nqslZe5k138eJZH2L5KrwR7i
> J1Uq5ZIZHa+Q9+aWCBeRVpb8RU+VnBx2nVBUQ98ovQ/ShDCE3SNGOwNSQAQtz8si
> LzXd4MfTmFZJSk4DwlTXXOAoXcYn6rwRdxr2DsyOa/faOeBwWrBVLrKfGN4Bl1rn
> MYEDLvQqZQ7T3FHik4aOHVUmvfYvJKaP1X+oAcHgM5WJpHhYmURf1wAMY8QgrI4=
> =tufN
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice