Re: [Libreoffice] minor idl fixes

On 05/01/12 09:38, Tomas Hlavaty wrote:
> Hi Stephan,
>
> Stephan Bergmann <sbergman@redhat.com> writes:
>
> > On 01/04/2012 11:09 PM, Tomas Hlavaty wrote:
> >
> > > diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl
> > > b/offapi/com/sun/star/chart/XAxisSupplier.idl
> > > ...
> >
> > Are you sure that this is right, using chart2 entities from within
> > chart?  I always intuitively thought that chart2 was a second attempt,
> > to replace chart.
>
> I am not sure as I don't know what chart and chart2 are about but
> currently this is broken.  The patch fixes the compilation issue.  Maybe
> I should move the file to chart2 package instead?

argh... that would not work, because there is already a chart2::XAxis.
in addition to chart::XAxis.  actually the chart::XAxis is newer than
chart2::XAxis: it was added for OOo 3.4, in commit
0c1fb57fe1588ba0d2ed07145fd07e834c96623f

the implementation of this is in
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx, and it uses
chart::XAxis.

by now i'm now pretty confused, but i think the proposed patch is wrong.

ah, your trouble could be caused by chart/XAxis.idl and chart2/XAxis.idl
having the same include guard, i'll try to fix that...

grmbl, what a mess...