Re: [Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes

Tomas Hlavaty <tom -AT- logand.com>
Thu, 05 Jan 2012 21:17:44 +0100

Hi Michael,

Michael Stahl <mstahl@redhat.com> writes:

thanks for these patches, i've pushed
0001-fix-broken-ifndef-define-guard-in-idl.patch,
0002-fix-package-in-idl.patch, 0005-chmod-x-on-java-files.patch.


great!

0003-idl-fix-package-names.patch seems to be wrong, as discussed in the
other mail (and i've fixed the duplicate include guard instead), and


Thank you, I didn't notice the include guard bug.

0006-follow-idl-definition.patch/0007-JavaLoader-actually-implements-XImplementationLoader.patch
were NACKed by Stephan due to backward compatibility.

OK.

btw, next time please add [PATCH] to the subject so these are more
visible to devs :)


I will.

Best Regards,

Tomas

Context

Re: [Libreoffice] minor idl fixes · Tomas Hlavaty
- Re: [Libreoffice] minor idl fixes · Stephan Bergmann
  - Re: [Libreoffice] minor idl fixes · Tomas Hlavaty
    - Re: [Libreoffice] minor idl fixes · Stephan Bergmann
      - Re: [Libreoffice] minor idl fixes · Tomas Hlavaty
    - Re: [Libreoffice] minor idl fixes · Michael Stahl
- Re: [Libreoffice] minor idl fixes · Michael Meeks
  - Re: [Libreoffice] minor idl fixes · Tomas Hlavaty
- [Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes · Michael Stahl
  - Re: [Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes · Tomas Hlavaty

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.